feat(pack): add pack-gzip-level #6406
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This options allows specifying custom compression level. Underlying node implementation enforces correct number ranges, but silently ignores `NaN`, so we explicitly check that provided value is valid. fix pnpm#6393
|
💖 Thanks for opening this pull request! 💖 |
jankaifer
commented
Apr 16, 2023
zkochan
reviewed
Apr 16, 2023
zkochan
changed the title
jankaifer
commented
Apr 16, 2023
There was a problem hiding this comment.
I think you forgot to pass that option here:
https://github.com/pnpm/pnpm/pull/6406/files#diff-c518d24f9667ad9a2c03aaa643610621010dcfb05670c326948311d7088bab10R115
EDIT: fixed
zkochan
force-pushed
the
jankaifer/6393-make-pnpm-pack-complersion-configurable
branch
from
21b5e8d
to
feb3254
Compare
zkochan
approved these changes
Apr 16, 2023
|
Congrats on merging your first pull request! 🎉🎉🎉 |
|
Thanks a bunch for your help. |
nipunn1313
reviewed
Apr 27, 2023
| @@ -30,6 +30,9 @@ export function rcOptionsTypes () { | |||
| export function cliOptionsTypes () { | |||
| return { | |||
| 'pack-destination': String, | |||
| ...pick([ | |||
| 'pack-gzip-level', | |||
There was a problem hiding this comment.
Consider also adding this to help() below so it shows up in pnpm pack --help for discoverability?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This options allows specifying custom compression level.
Underlying node implementation enforces correct number ranges,
but silently ignores
NaN, so we explicitly check that provided value is valid.More information about this
leveloption can be found in node docs and zlib specs.Supported values are (
6is default in node):I didn't add any test but I tested manually
that compressing with
-1,0and1create an installable package.Also tested manually that using
pnpm config set pack-gzip-level 0and--pack-gzip-level=0both work as expected.fix #6393