fix: update node-fetch for node v20 compatibility

[jakebailey]

Fixes #6424 (probably)

Unfortunately, the old version of fetch appears to still be in the lockfile. I'm pretty sure that's because there are some cycles caused by @pnpm/meta-updater which depends on a bunch of old pnpm monorepo packages which are duplicating the tree.

[jakebailey]

This is a bit of a chicken and egg problem, can't add tests for Node 20 because pnpm depends on pnpm to install.

[zkochan]

isn't the latest node-fetch esm only?

[jakebailey]

Apparently; I guess I didn't hit this in my own testing becuase the pnpm output is bundled and so doesn't hit this, but tests are not bundled so do.

Not quite sure what to do here.

[zkochan]

The older version is not compatible with node.js v20?

[jakebailey]

It would seem not, from my testing.

Given fetch is async, I do wonder if it could be async imported (not sure if that works while bundled), or, if we could just use the built-in fetch on newer versions of Node instead (since it's available in Node 18+?). I think use of node-fetch is pretty consolidated so that might be a good option.

Feel free to test things out on Node 20 separately; I just updated to see and was surprised to have this failure.

[zkochan]

I'd rather not use different implementations on different versions.

If it is broken maybe we should fork it and make a fix. Or find an alternative.

[zkochan]

Is undici the one that comes bundled with node.js? We can try to use it instead.

But I don't think it will be easy to migrate from node-fetch.

[so1ve]

How about using node-native-fetch? It uses expetimental built-in fetch if possible.

[zkochan]

It doesn't matter. If we will use native only on some versions than pnpm will behave differently on different versions and it will be harder to investigate bugs.

I have forked node-fetch: https://github.com/pnpm/node-fetch