feat: expanded missing command error, including 'did you mean'

[JoshuaKGoldberg]

Fixes #6492

For both the exec and run commands, adds a hint property based on a new buildCommandNotFoundHint utility.

Reuses the didyoumean2 package already used elsewhere in pnpm (and, fun fact, npm & yarn!).

Co-authored-by: Zoltan Kochan z@kochan.io

[welcome]

💖 Thanks for opening this pull request! 💖
Please be patient and we will get back to you as soon as we can.

[zkochan]

Create a changeset

[zkochan]

Looks like it doesn't work on Windows.

[zkochan]

This is the error message on Windows:

Error: Command failed with exit code 1: xxxx
    at makeError (C:\Users\zolta\src\pnpm\pnpm\pnpm\dev\dist\pnpm.cjs:24357:17)
    at handlePromise (C:\Users\zolta\src\pnpm\pnpm\pnpm\dev\dist\pnpm.cjs:24928:33)
    at processTicksAndRejections (node:internal/process/task_queues:96:5)
    at async C:\Users\zolta\src\pnpm\pnpm\pnpm\dev\dist\pnpm.cjs:207718:11 {
  shortMessage: 'Command failed with exit code 1: xxxx',
  command: 'xxxx',
  escapedCommand: 'xxxx',
  exitCode: 1,
  signal: undefined,
  signalDescription: undefined,
  stdout: undefined,
  stderr: undefined,
  failed: true,
  timedOut: false,
  isCanceled: false,
  killed: false
}

it doesn't have the original message. So, I am not sure how we can know the reason it failed.

I guess we could use which to see if the command exists

[JoshuaKGoldberg]

(putting this into draft as I won't have a Windows computer for a few days) ✅

[JoshuaKGoldberg]

🤔 if I add an else after this locally, then the command properly throws err after setting err.hint. But without the else, we only get the exitCode = err.exitCode. Is there a reason to run the if (!opts.recursive ... check if we know the failure is from the command not being found?

[zkochan]

The tests fail now because of @zkochan/which. I need to update my fork.

[welcome]

Congrats on merging your first pull request! 🎉🎉🎉