fix: special version node check #6509
Conversation
|
💖 Thanks for opening this pull request! 💖 |
| @@ -6,7 +6,7 @@ export function getSystemNodeVersionNonCached () { | |||
| if (process['pkg'] != null) { | |||
| return execa.sync('node', ['--version']).stdout.toString() | |||
| } | |||
| return process.version | |||
| return process.version.replace(/-.*$/, '') | |||
There was a problem hiding this comment.
why is this change required? Is it because it currently fails when checking if the node.js version satisfies the range in the engines field? I think in that case this change should be done before passing the version to semver. This function may be used also to print the node.js version and in that case I think we should return the correct version. Also, the way you did it, doesn't cover line 7.
There was a problem hiding this comment.
Yes, I installed version v21.0.0-nightly20230429c968361829 to test a function of node. When I run the project, its engine.node field value ^14.18.0 || >=16.0.0 check will fail. Running it with npm will work fine.
I think in that case this change should be done before passing the version to semver.
You mean maybe we should change here?
This function may be used also to print the node.js version and in that case I think we should return the correct version. Also, the way you did it, doesn't cover line 7.
I was negligent, I didn't think about these before. If we modify it in the above way, there is no need to change it here.
There was a problem hiding this comment.
Yes, that looks like the right place for the change.
![github-advanced-security[bot]](https://avatars.githubusercontent.com/in/57789?s=60&v=4){kind=small}
|
Congrats on merging your first pull request! 🎉🎉🎉 |
|
@zkochan Thank you for your efficient and hard work! ❤️ |
--------- Co-authored-by: Zoltan Kochan <z@kochan.io>
refer to https://github.com/npm/cli/blob/bdab631b9847013dc4e8d4083669acf6c7bfb457/lib/cli.js#L16