feat: include some settings as fields in the lockfile #6557
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
weyert
approved these changes
May 20, 2023
zkochan
added a commit
that referenced
this pull request
May 30, 2023
chris-olszewski
added a commit
to vercel/turbo
that referenced
this pull request
Jun 5, 2023
### Description Adds parse support for the new lockfile version added in pnpm/pnpm#6557 fixing #5117 The behavioral change is pretty small for us. The new information was added to allow for `pnpm install --frozen-lockfile` to produce an identical lockfile even if the `.npmrc` that was present during the lockfile's creation is no longer present. This does lead to a better UX for prune users as they will no longer need to copy `.npmrc` in their `Dockerfile`. ### Testing Instructions Existing unit tests pass and added new fixture with the settings field that correctly parses. --------- Co-authored-by: Chris Olszewski <Chris Olszewski>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
ref #6312
Some settings influence the structure of the lockfile, so we cannot reuse the lockfile if those settings change. As a result, we need to store such settings in the lockfile. This way we will know with which settings the lockfile has been created.