fix: lifecycle buildindex sort #6568
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
💖 Thanks for opening this pull request! 💖 |
zkochan
approved these changes
May 20, 2023
|
Congrats on merging your first pull request! 🎉🎉🎉 |
zkochan
pushed a commit
that referenced
this pull request
May 20, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
when I use pnpm with workspace, I found that the execution order of lifecycle script is wrong. When the maximum value of buildIndex is greater than
10, this problem will be caused. The reason is that when sorting buildIndex, because the type of buildIndex is number, no compare function is added, resulting in disordered order after sorting.In the figure below, the following one is expected