Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: link local bins created by postinstall scripts #6728

Merged
merged 3 commits into from
Jun 29, 2023
Merged

fix: link local bins created by postinstall scripts #6728

merged 3 commits into from
Jun 29, 2023

Conversation

zkochan
Copy link
Member

@zkochan zkochan commented Jun 28, 2023

close #1801

@zkochan zkochan requested a review from a team June 29, 2023 00:23
Copy link
Member

@BlackHole1 BlackHole1 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@zkochan zkochan merged commit dddb8ad into main Jun 29, 2023
13 of 14 checks passed
@zkochan zkochan deleted the fix/1801 branch June 29, 2023 08:59
zkochan added a commit that referenced this pull request Jun 30, 2023
@kenbankspeng
Copy link

FYI. Using pnpm v8.6.6 which has this PR, still seeing WARN  Failed to create bin... and subsequent Error [ERR_MODULE_NOT_FOUND] associated with postinstall.

pnpm install                           

 WARN  Failed to create bin at .../node_modules/supabase postinstall$ node scripts/postinstall.js
│ node:internal/errors:496
│     ErrorCaptureStackTrace(err);
│     ^
│ Error [ERR_MODULE_NOT_FOUND]: Cannot find package 'bin-links' imported from …
│     at new NodeError (node:internal/errors:405:5)
│     at packageResolve (node:internal/modules/esm/resolve:781:9)
│     at moduleResolve (node:internal/modules/esm/resolve:830:20)
│     at defaultResolve (node:internal/modules/esm/resolve:1035:11)
│     at DefaultModuleLoader.resolve (node:internal/modules/esm/loader:269:12)
│     at DefaultModuleLoader.getModuleJob (node:internal/modules/esm/loader:153:32)
│     at ModuleWrap.<anonymous> (node:internal/modules/esm/module_job:76:33)
│     at link (node:internal/modules/esm/module_job:75:36) {
│   code: 'ERR_MODULE_NOT_FOUND'
│ }

@zkochan
Copy link
Member Author

zkochan commented Jul 4, 2023

I don't know what your issue is about. You can see in the PR that the change is covered with a test. If you have some issue, create an issue with steps to reproduce or even better with a repository that reproduces it.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

pnpm install recursive fails with bin in sub package that must be compiled first
3 participants