Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(dependencies-hierarchy): fix loading multiple copies of lockfile #6757

Merged
merged 1 commit into from Jul 3, 2023

Conversation

zxbodya
Copy link
Contributor

@zxbodya zxbodya commented Jul 3, 2023

Moving loading wantedLockfile outside dependenciesHierarchyForPackage, reducing memory usage and preventing OOM crash on larger cases when loading the same lock file too many times

Flame graph running pnpm why

before:
Screenshot 2023-07-03 at 14 48 46

after:
Screenshot 2023-07-03 at 14 49 11

…endenciesHierarchyForPackage

Move loading wantedLockfile outside dependenciesHierarchyForPackage,
preventing OOM crash when loading the same lock file too many times
@zxbodya zxbodya requested a review from zkochan as a code owner July 3, 2023 12:50
@zkochan zkochan merged commit e334e56 into pnpm:main Jul 3, 2023
8 checks passed
@zxbodya zxbodya deleted the fix-lockfile-duplicates branch July 3, 2023 13:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants