Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

perf(modules-cleaner): replace ramda difference with better alternative #6760

Merged
merged 1 commit into from Jul 3, 2023
Merged

perf(modules-cleaner): replace ramda difference with better alternative #6760

merged 1 commit into from Jul 3, 2023

Conversation

zxbodya
Copy link
Contributor

@zxbodya zxbodya commented Jul 3, 2023

Ramda's difference happens to be slow, for the case how it is used in prune function.

before:
Screenshot 2023-07-03 at 20 59 08

after:
Screenshot 2023-07-03 at 20 59 38

@zxbodya zxbodya requested a review from zkochan as a code owner July 3, 2023 19:00
@zkochan zkochan merged commit 6fb5da1 into pnpm:main Jul 3, 2023
8 checks passed
@zxbodya zxbodya deleted the perf-ramda-difference branch July 3, 2023 20:33
@zkochan
Copy link
Member

zkochan commented Jul 3, 2023

Thanks for all the optimizations. The results are great!

@jakebailey
Copy link
Member

pprof ❤️

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@zkochan zkochan zkochan approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@zxbodya @zkochan @jakebailey