feat(env): allow installing and removing multiple NodeJS versions at once #7155
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
💖 Thanks for opening this pull request! 💖 |
zkochan
reviewed
Oct 1, 2023
zkochan
reviewed
Oct 3, 2023
Comment on lines
13
to
17
| const message = await downloadNodeVersion(opts, version) | ||
| if (message instanceof Error) { | ||
| globalWarn(message.message) | ||
| errors.push(message) | ||
| } |
There was a problem hiding this comment.
I think it will make more sense to throw an error in downloadNodeVersion and catch it here. Also less code in envUse
There was a problem hiding this comment.
I'm not partial to exceptions as control flow...
Really bypasses type safety.
But that is already what a lot of this code is doing...
😢
There was a problem hiding this comment.
Then return null instead of an error.
zkochan
changed the title
zkochan
approved these changes
Oct 5, 2023
|
Congrats on merging your first pull request! 🎉🎉🎉 |
|
Thanks for taking the time to wrap it up. I have other changes I want to make and this first PR really helped get a better feel for the style you'd want. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR:
env rmto accept multiple versions, removing all of them at onceenv addto allow installing multiple versions at once without setting them as default (like in the case ofenv use)Some refactoring to dedupe code. I could go further with that, but I was trying to preserve as much of the existing structure and style as possible along the way. Not sure how opinionated the team is on that structure, or if a more aggressive sweep could make sense