fix: do not run node-gyp rebuild if preinstall lifecycle script is present #7206
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
💖 Thanks for opening this pull request! 💖 |
|
Thanks for tracking down the issue. |
zkochan
approved these changes
Oct 15, 2023
|
Congrats on merging your first pull request! 🎉🎉🎉 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
According to npm documentation:
However, in the case of
pnpm, this check was only performed if an install script was defined, resulting in a discrepancy between the behavior of npm and pnpm. You can refer to this GitHub issue for more information: aws/aws-lambda-nodejs-runtime-interface-client#78.This pull request modifies
pnpmto executenode-gyp rebuildonly when neither the preinstall nor the install scripts are defined.