pnpm import does not preserve locked versions from package-lock.json #7298
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I have taken a look at this and we correctly pull the versions out of the shrinkwrap/package-lock file, but when they are passed into recursive() in opts.prefferedVersions, they are no longer associated with the specific dependency. Then I assume because the high version meets the criteria (^1.x.x) the higher version is selected as matching. This can be changed but would require some change in the data structures to keep the version extracted from the package-lock.json associated with the correct packages. Want to get @zkochan thoughts before I look into it too much more |
|
updated to work with the new v9 format lockfiles, still an issue |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a failing test to demonstrate issue #7287