feat(reporter): print install summary for workspace sub projects #7306
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
await-ovo
commented
Nov 13, 2023
| @@ -298,6 +298,9 @@ test('prints summary without the filtered out entries', (done) => { | |||
| expect(output).toBe(EOL + `\ | |||
| ${h1('dependencies:')} | |||
| ${ADD} foo ${versionColor('1.0.0')} ${versionColor('(2.0.0 is available)')} | |||
| ` + EOL + `\ | |||
There was a problem hiding this comment.
I'm not sure why this test kept giving an error on my branch, but after this change, both the main branch and the current branch workes fine.
It seems to actually print that a dev dependency qar has been added ?
|
The output is massive on first install. Maybe we should only show it when running install on a node_modules that already exists. In that case the output should be smaller. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
close #6481
The install summary of changed sub-projects will always be printed like the following: