Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

dynamic trend image #7331

Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

dynamic trend image #7331

wants to merge 1 commit into from

Conversation

cwtuan
Copy link
Contributor

@cwtuan cwtuan commented Nov 19, 2023

Instead of using a static image, this image could be dynamically updated

@cwtuan cwtuan requested a review from zkochan as a code owner November 19, 2023 02:53
@zkochan
Copy link
Member

zkochan commented Nov 21, 2023

It doesn't seem to work

image

@cwtuan
Copy link
Contributor Author

cwtuan commented Nov 26, 2023

Following a thorough investigation into this issue, it has come to my attention that the adding of an externally hosted image in GitHub's README results in caching through the camo service.

The loading of image in camo may be failed for the first user because the cache is absent. Subsequently, other users will direct viewing of the cached image in camo successfully.

In order to validate this process, I tested the viewing of the cached image across different networks and devices after camo had successfully cached it. Fortunately, I encountered no issues in this regard.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants