Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(reviewing): filter the same print message #7430

Merged
merged 4 commits into from Dec 26, 2023

Conversation

btea
Copy link
Contributor

@btea btea commented Dec 16, 2023

fix #7429

@btea btea requested a review from zkochan as a code owner December 16, 2023 01:40
@btea btea changed the title fix(list): filter the same print message fix(reviewing): filter the same print message Dec 16, 2023
@zkochan
Copy link
Member

zkochan commented Dec 21, 2023

I don't think this is the right fix. We should figure out why there are duplications at all.

@btea
Copy link
Contributor Author

btea commented Dec 26, 2023

I've updated the code and added relevant comments.

@zkochan zkochan merged commit 09f6103 into pnpm:main Dec 26, 2023
9 of 10 checks passed
@btea btea deleted the fix/filter-list-print-info branch December 26, 2023 11:55
gluxon pushed a commit to gluxon/pnpm that referenced this pull request Dec 27, 2023
close pnpm#7429

---------

Co-authored-by: Zoltan Kochan <z@kochan.io>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

pnpm list --depth Infinity --parseable should remove duplicate print
2 participants