Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add hoist-workspace-packages option #7451

Merged
merged 29 commits into from Dec 30, 2023
Merged

feat: add hoist-workspace-packages option #7451

merged 29 commits into from Dec 30, 2023

Conversation

nachoaldamav
Copy link
Contributor

No description provided.

@nachoaldamav nachoaldamav marked this pull request as ready for review December 21, 2023 16:20
Copy link
Member

@zkochan zkochan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Add some tests to verify that it works.

@nachoaldamav
Copy link
Contributor Author

Add some tests to verify that it works.

Where should I add the tests? The hoist package doesn't have tests yet

@zkochan
Copy link
Member

zkochan commented Dec 26, 2023

in pkg-manager/core/test/install/hoist.ts

pkg-manager/hoist/src/index.ts Outdated Show resolved Hide resolved
pkg-manager/hoist/src/index.ts Outdated Show resolved Hide resolved
@zkochan
Copy link
Member

zkochan commented Dec 28, 2023

you're still reading the package name from the package.json, even though this information is present in allProjects.

@nachoaldamav
Copy link
Contributor Author

you're still reading the package name from the package.json, even though this information is present in allProjects.

Where? I removed all the references to that in the last commit

[project.id]: path.normalize(path.relative(workspace.rootDir, project.rootDir)),

I just added a new commit to get the package name from the allProjects in the symlink function (before it was using the path).

@zkochan zkochan changed the title feat: add hoistWorkspaceProjects option feat: add hoist-workspace-packages option Dec 30, 2023
@zkochan zkochan enabled auto-merge (squash) December 30, 2023 13:04
@zkochan zkochan merged commit c597f72 into main Dec 30, 2023
18 checks passed
@zkochan zkochan deleted the hoist-ws-projects branch December 30, 2023 13:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants