Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: skip automatic download/install of Node.js versions in WebContainer #7478

Merged
merged 2 commits into from Jan 2, 2024
Merged

fix: skip automatic download/install of Node.js versions in WebContainer #7478

merged 2 commits into from Jan 2, 2024

Conversation

kirjavascript
Copy link
Contributor

The automatic install feature causes PNPM to throw and fail in WebContainer as downloading different versions is not supported on that target.

This skips the download/install in WebContainer and allows PNPM to continue functioning with a warning.

Copy link

welcome bot commented Jan 2, 2024

💖 Thanks for opening this pull request! 💖
Please be patient and we will get back to you as soon as we can.

@zkochan zkochan merged commit 8d7ec24 into pnpm:main Jan 2, 2024
10 checks passed
Copy link

welcome bot commented Jan 2, 2024

Congrats on merging your first pull request! 🎉🎉🎉

@kirjavascript
Copy link
Contributor Author

thanks for cleaning this up and merging!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants