Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: use real path for module root dir (#6524) #7491

Merged
merged 4 commits into from Jan 8, 2024
Merged

fix: use real path for module root dir (#6524) #7491

Show file tree
Hide file tree
Changes from 2 commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
227c903
fix: use real path for module root dir (#6524)
grimly Jan 4, 2024
5a2f831
fix: use the real path for the local package (#6524)
grimly Jan 7, 2024
2161421
refactor: uses synchronized api as suggested
grimly Jan 8, 2024
2b3a76f
docs: add changeset and comment
zkochan Jan 8, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Jump to
Jump to file
Failed to load files.
Diff view
Diff view
5 changes: 5 additions & 0 deletions .changeset/real-knives-bathe.md
View file
Open in desktop
@@ -0,0 +1,5 @@
---
"@pnpm/config": patch
---

Fixes the local package real path
2 changes: 1 addition & 1 deletion config/config/src/index.ts
View file
Open in desktop
Expand Up @@ -291,7 +291,7 @@ export async function getConfig (
...rcOptions.map((configKey) => [camelcase(configKey), npmConfig.get(configKey)]) as any, // eslint-disable-line
...Object.entries(cliOptions).filter(([name, value]) => typeof value !== 'undefined').map(([name, value]) => [camelcase(name), value]),
]) as unknown as ConfigWithDeprecatedSettings
const cwd = betterPathResolve(cliOptions.dir ?? npmConfig.localPrefix)
const cwd = await fs.promises.realpath(betterPathResolve(cliOptions.dir ?? npmConfig.localPrefix))
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You can make this operation synchronous as we don't run anything concurrently at this point.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I know for a fact you are already asynchronous really early in this function.
Also you do not start additional tasks so it should not be a problem.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

That can be changed too. But not in this PR. Sync fs operations in Node.js are faster unless you can run them in parallel to something else.


pnpmConfig.maxSockets = npmConfig.maxsockets
// @ts-expect-error
Expand Down