fix(plugin-commands-publishing): should pack main file or bin files defined in publishConfig

[await-ovo]

fix #4195

Following @popeindustries's suggestion, we can create publishManifest before pack tarball, and then use the packageJsonCache option in npm-packlist to avoid loading pacakge.json from the local filesystem, which should ensure that the final list of files in packed tarball is the one that needs to be published.

[snicol21]

I believe this appears to have broken our build

I've been using clean-package in conjunction with pnpm for my builds.

our pnpm pack used to generate a structure that looked like this:

.
└── package/
└── dist/
└── ...

but since this patch went in 13 hrs ago it started including a single index.ts file within the published package

.
└── package/
├── dist/
│ └── ...
└── src/
└── index.ts

which is now breaking all consumers of our packages.

[await-ovo]

@snicol21 Hi, can you provide a repository that reproduces the above problem?

[snicol21]

@snicol21 Hi, can you provide a repository that reproduces the above problem?

Thanks @await-ovo , here's a quick repo I put together and was able to recreate the issue. I added some details to the README.md

https://github.com/snicol21/my-ts-pnpm

[await-ovo]

@snicol21 Hi, can you provide a repository that reproduces the above problem?

Thanks @await-ovo , here's a quick repo I put together and was able to recreate the issue. I added some details to the README.md

https://github.com/snicol21/my-ts-pnpm

Thanks for the detailed steps to reproduce the problem, I think I know what the problem is, I'll send a pr to fix this later ~

[snicol21]

@snicol21 Hi, can you provide a repository that reproduces the above problem?

Thanks @await-ovo , here's a quick repo I put together and was able to recreate the issue. I added some details to the README.md

https://github.com/snicol21/my-ts-pnpm

Thanks for the detailed steps to reproduce the problem, I think I know what the problem is, I'll send a pr to fix this later ~

Awesome! Thanks for your help.