Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: package with unsupported platform should return false to skip download #7551

Open
wants to merge 5 commits into
base: main
Choose a base branch
from

Conversation

suhaotian
Copy link

@suhaotian suhaotian commented Jan 22, 2024

How to reproduce?

git clone https://github.com/ts-monorepo/basic
cd basic 
pnpm install 

First time install will be ok;

Install again will show the unnecessary download details

pnpm install

image

After fix, Now:

image

Copy link

welcome bot commented Jan 22, 2024

💖 Thanks for opening this pull request! 💖
Please be patient and we will get back to you as soon as we can.

@suhaotian
Copy link
Author

suhaotian commented Jan 22, 2024

Have some tests failed, no idea how to fix

image

@zkochan
Copy link
Member

zkochan commented Jan 26, 2024

We should fix it for sure but I am not sure your fix is correct. As far as I remember there was a reason I added force: true.

@suhaotian suhaotian closed this Jan 28, 2024
@suhaotian suhaotian reopened this Jan 28, 2024
@suhaotian
Copy link
Author

Yeah good point, I'm cheking, but no idea how to fix this..

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Status: Priority
Development

Successfully merging this pull request may close these issues.

None yet

2 participants