feat: pnpm.ignoredOptionalDependencies #7714
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
KSXGitHub
force-pushed
the
ignored-optional-dependencies
branch
from
d5395e2
to
0bcf912
Compare
KSXGitHub
commented
Feb 27, 2024
zkochan
reviewed
Feb 27, 2024
There was a problem hiding this comment.
This test should be moved to core too.
|
|
||
| function removeOptionalDependencies<Manifest extends BaseManifest> (manifest: Manifest, toBeRemoved: string[]): Manifest { | ||
| for (const optionalDependency in manifest.optionalDependencies) { | ||
| if (toBeRemoved.includes(optionalDependency)) { |
There was a problem hiding this comment.
probably we need to support pattern matching. Same way like here:
zkochan
approved these changes
Feb 28, 2024
Open
4 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.