fix: correctly detect the active Node js version during headless installation

config/package-is-installable/src/index.ts

@@ -11,6 +11,7 @@ export type { Engine } from './checkEngine'
 export type { Platform, WantedPlatform } from './checkPlatform'
 
 export {
+  getSystemNodeVersion,
   UnsupportedEngineError,
   UnsupportedPlatformError,
   type WantedEngine,

pkg-manager/core/package.json

@@ -43,6 +43,7 @@
     "@pnpm/modules-yaml": "workspace:*",
     "@pnpm/normalize-registries": "workspace:*",
     "@pnpm/npm-package-arg": "^1.0.0",
+    "@pnpm/package-is-installable": "workspace:*",
     "@pnpm/package-requester": "workspace:*",
     "@pnpm/parse-wanted-dependency": "workspace:*",
     "@pnpm/pkg-manager.direct-dep-linker": "workspace:*",

pkg-manager/core/src/install/extendInstallOptions.ts

@@ -6,6 +6,7 @@ import { createReadPackageHook } from '@pnpm/hooks.read-package-hook'
 import { type Lockfile } from '@pnpm/lockfile-file'
 import { type IncludedDependencies } from '@pnpm/modules-yaml'
 import { normalizeRegistries, DEFAULT_REGISTRIES } from '@pnpm/normalize-registries'
+import { getSystemNodeVersion } from '@pnpm/package-is-installable'
 import { type WorkspacePackages } from '@pnpm/resolver-base'
 import { type StoreController } from '@pnpm/store-controller-types'
 import {
@@ -187,7 +188,7 @@ const defaults = (opts: InstallOptions) => {
     },
     lockfileDir: opts.lockfileDir ?? opts.dir ?? process.cwd(),
     lockfileOnly: false,
-    nodeVersion: process.version,
+    nodeVersion: opts.nodeVersion ?? getSystemNodeVersion(),
     nodeLinker: 'isolated',
     overrides: {},
     ownLifecycleHooksStdio: 'inherit',

pkg-manager/core/test/install/headlessInstallationChecks.ts

@@ -0,0 +1,36 @@
+import { prepareEmpty } from '@pnpm/prepare'
+import { getSystemNodeVersion } from '@pnpm/package-is-installable'
+import {
+  addDependenciesToPackage,
+  install,
+} from '@pnpm/core'
+import { testDefaults } from '../utils'
+
+jest.mock('@pnpm/package-is-installable', () => ({
+  ...jest.requireActual('@pnpm/package-is-installable'),
+  getSystemNodeVersion: jest.fn(() => process.version),
+}))
+
+afterEach(() => {
+  jest.mocked(getSystemNodeVersion).mockRestore()
+})
+
+test('do not fail if package supports the system Node and engine-strict = true', async () => {
+  const project = prepareEmpty()
+
+  const manifest = await addDependenciesToPackage({},
+    [
+      '@pnpm.e2e/for-legacy-node',
+    ],
+    testDefaults()
+  )
+
+  const lockfile = project.readLockfile()
+  expect(lockfile.packages['/@pnpm.e2e/for-legacy-node@1.0.0'].engines).toStrictEqual({ node: '0.10' })
+
+  await expect(install(manifest, testDefaults({ engineStrict: true }))).rejects.toThrow()
+
+  jest.mocked(getSystemNodeVersion).mockImplementation(() => '0.10.0')
+
+  await expect(install(manifest, testDefaults({ engineStrict: true }))).resolves.not.toThrow()
+})

pkg-manager/core/tsconfig.json

@@ -30,6 +30,9 @@
     {
       "path": "../../config/normalize-registries"
     },
+    {
+      "path": "../../config/package-is-installable"
+    },
     {
       "path": "../../crypto/object-hasher"
     },