Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: ordering workspace projects that are in peer dependencies #7821

Merged
merged 1 commit into from Mar 24, 2024

Conversation

zkochan
Copy link
Member

@zkochan zkochan commented Mar 24, 2024

close #7813

@zkochan zkochan merged commit ca2be03 into main Mar 24, 2024
14 checks passed
@zkochan zkochan deleted the fix/7813 branch March 24, 2024 10:35
@levrik
Copy link

levrik commented Apr 2, 2024

Just this morning I fixed a cyclic workspace dependencies warning through peer dependencies but with this update is happens again. I don't know if peer dependencies not being included in the cyclic workspace check was on purpose or not.

Just to elaborate a bit on the setup I'm having: components has dependency on icons while icons has a dependency on components. This is done this way as icons uses the Icon base component from components but icons then includes a specific set of icons using this primitive component under the hood. components itself uses something from this icon set in some components so it has a dependency on icons. I thought defining components as a peer dependency in icons would be the correct solution which also removed the warning in 8.15.5 but started to re-appear in 8.15.6.

Now I wonder: Was using peers expected to allow such semi-cyclic dependency structures (making this a regression) or was it never intended do work like this (making this a fix also for a missing warning)?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

peerDependencies do not participate in ordering
2 participants