Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(prune): add --ignore-scripts arg to prune command #7836

Merged
merged 1 commit into from Mar 27, 2024
Merged

fix(prune): add --ignore-scripts arg to prune command #7836

merged 1 commit into from Mar 27, 2024

Conversation

colincasey
Copy link
Contributor

Fixes #5030

@welcome Welcome
Copy link

welcome bot commented Mar 27, 2024

💖 Thanks for opening this pull request! 💖
Please be patient and we will get back to you as soon as we can.

@zkochan
Copy link
Member

zkochan commented Mar 27, 2024

How would this change fix the issue? It only adds the flag to the help output.

@colincasey
Copy link
Contributor Author

@zkochan it also adds it to the cliOptionsTypes so it gets parsed and passed along to the prune command which then forwards it along to install.handler(...) used internally by prune.handler(...).

@zkochan zkochan merged commit d4e13ca into pnpm:main Mar 27, 2024
8 checks passed
@welcome Welcome
Copy link

welcome bot commented Mar 27, 2024

Congrats on merging your first pull request! 🎉🎉🎉

@colincasey colincasey mentioned this pull request Mar 28, 2024
Merged
@colincasey colincasey deleted the allow_prune_to_ignore_scripts branch March 28, 2024 14:55
zkochan pushed a commit that referenced this pull request Mar 29, 2024
@colincasey @zkochan
fix(prune): add --ignore-scripts arg to prune command (#7836)
a03e331 
close #5030
mohanaprasath-pentafox

This comment was marked as outdated.

Sign in to view

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mohanaprasath-pentafox mohanaprasath-pentafox mohanaprasath-pentafox left review comments

@zkochan zkochan zkochan approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

pnpm prune --prod reruns postinstall script
3 participants
@colincasey @zkochan @mohanaprasath-pentafox