ci: test on Node.js 22 #8010
Open
ci: test on Node.js 22 #8010
+4
−4
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
weyert
approved these changes
Apr 24, 2024
| @@ -17,7 +17,7 @@ jobs: | |||
| node: | |||
| - '18.12' | |||
| - '20' | |||
| - '21' | |||
There was a problem hiding this comment.
We don't want to test against v21?
There was a problem hiding this comment.
v21 is not an lts version. When 22 is out, v21 is basically deprecated.
There was a problem hiding this comment.
as you can see, we don't test v19 as well.
weyert
approved these changes
Apr 24, 2024
| @@ -43,8 +43,8 @@ jobs: | |||
| with: | |||
| node-version: ${{ matrix.node }} | |||
| cache: 'pnpm' | |||
| - name: Install npm@7 | |||
| run: npm add --global npm@7 | |||
| - name: Install npm@10 | |||
There was a problem hiding this comment.
npm v10 appears to require a minimum version of Node v20.
Do we want to do a matrix of node-version and npc-version to accommodate for this?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.