Skip to content

Commit

Permalink
Don't test with aiohttp 3.6 and older on Python 3.10
Browse files Browse the repository at this point in the history
aiohttp 3.6 and older use Python features which were removed in Python
3.10:

                assert port is not None
    >           hosts = await asyncio.shield(self._resolve_host(
                    host,
                    port,
                    traces=traces), loop=self._loop)
    E               TypeError: shield() got an unexpected keyword argument 'loop'

    .tox/py3.10-aiohttp35/lib/python3.10/site-packages/aiohttp/connector.py:952: TypeError

To avoid test failures, we remove unsupported combinations from GitHub
workflows.
  • Loading branch information
marcinsulikowski committed Oct 19, 2022
1 parent 3e22b60 commit afd9bf9
Showing 1 changed file with 0 additions and 4 deletions.
4 changes: 0 additions & 4 deletions .github/workflows/ci.yml
Original file line number Diff line number Diff line change
Expand Up @@ -54,10 +54,6 @@ jobs:
- python-version: 3.9
aiohttp-version: aiohttp38

- python-version: "3.10"
aiohttp-version: aiohttp35
- python-version: "3.10"
aiohttp-version: aiohttp36
- python-version: "3.10"
aiohttp-version: aiohttp37
- python-version: "3.10"
Expand Down

0 comments on commit afd9bf9

Please sign in to comment.