Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Telegram auth #1561

Closed
wants to merge 1 commit into from
Closed

Add Telegram auth #1561

wants to merge 1 commit into from

Conversation

iamelevich
Copy link

This pull request will add Telegram Auth for Web App or with Login widget.

This is not OAuth2, but I need it for my telegram webapp, so I decided to integrate it inside pocketbase instead of adding new route, cause it can be useful for others I hope.

Please take a look. Still have some things to do:

  • Update js-sdk to support telegram auth
  • Update dart-sdk to support telegram auth
  • Update documentation

@ganigeorgiev
Copy link
Member

ganigeorgiev commented Jan 11, 2023

Sorry, I don't want to merge it.

If Telegram doesn't have OAuth2 api then this cannot be part of the core package. It will be just hard to maintain since I don't use Telegram and I can't provide support for it in case they decide to change their api(s).

You can structure it as server-side "plugin" and create a standalone Go package that accept core.App and use that to bind to the OnBeforeServe hook and others to register your custom endpoint(s).

Eventually in the future, we may also add support for Admin UI addons but for now this a low priority.

@iamelevich
Copy link
Author

Created a plugin if someone need such functionality. https://github.com/iamelevich/pocketbase-plugin-telegram-auth

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants