Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Patreon Auth #3323

Closed
wants to merge 4 commits into from
Closed

Add Patreon Auth #3323

wants to merge 4 commits into from

Conversation

ghostdevv
Copy link
Contributor

I based this off the Yandex commit 435eca6#diff-0c7bbc200a025d45ef4358425b0a3c41b8de1e8b9d5f4b94a09f1d5c612e4481 - let me know if there is anything missing and I will add it to this pr! I tested this auth with the pocketbase js sdk and also running make test and make lint

@ghostdevv
Copy link
Contributor Author

Submitted a PR to the oauth2 package to add the patreon endpoints golang/oauth2#668

@ghostdevv
Copy link
Contributor Author

ghostdevv commented Sep 16, 2023

Just thought of something - it might be worth mentioning somewhere that it requires Patreon api v2 keys to be given

ganigeorgiev added a commit that referenced this pull request Sep 16, 2023
Co-authored-by: GHOST <ghostdevbusiness@gmail.com>
@ganigeorgiev
Copy link
Member

Thank you! I've tested the implementation locally, with both creator and regular user/subscriber, and everything seems to work fine.

To avoid the back-and-forth, I've squash merged it directly in the develop branch (71f9be3) (I've added only v2 to the provider title).

If the Go team ended up merging the endpoints PR we can update it later, but even with the static endpoints is fine (at the end the userApiUrl will still be "hardcoded").

The change will be available with the next PocketBase v0.19.0 release, but please note that there are no fixed ETAs yet (see also #3271). If you want to generate a static binary from the develop branch similar to the releases prebuilt executables, you can:

  1. Checkout or clone the develop branch
    git clone https://github.com/pocketbase/pocketbase.git --branch develop --single-branch
  2. Navigate to examples/base
  3. Run GOOS=linux GOARCH=amd64 CGO_ENABLED=0 go build (https://go.dev/doc/install/source#environment)
  4. Start the created executable by running ./base serve.

@ghostdevv
Copy link
Contributor Author

Ty!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants