Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

PocoDoc: search support #4494

Open
wants to merge 5 commits into
base: main
Choose a base branch
from
Open

PocoDoc: search support #4494

wants to merge 5 commits into from

Conversation

vrabac6
Copy link

@vrabac6 vrabac6 commented Mar 13, 2024

The PocoDoc did not support integration with FTS5 SQLite database for the purpose of inputting clean content into the database. To enhance its functionality, the following improvements have been implemented:

  1. Expanded the writeDescription method by adding an output stream containing clean content.
  2. Introduced a new method named writeSearchIndex , responsible for retrieving textual documentation along with links. This method is called within existing methods writeClass , writePackage , and writeNameSpace

@aleks-f aleks-f linked an issue Mar 27, 2024 that may be closed by this pull request
Copy link
Member

@aleks-f aleks-f left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

  • Windows CI is failing; this needs update of vs90 project and regeneration of 160 and 170 projects
    D:\a\poco\poco\PocoDoc\src\DocWriter.cpp(29,10): error C1083: Cannot open include 
    file: 'Poco/Data/Session.h': No such file or directory 
    [D:\a\poco\poco\PocoDoc\PocoDoc_vs170.vcxproj]
    Error: Final attempt failed. Child_process exited with error code 1```
  • to prevent sanitizer CI failures, either pick these changes or simply merge devel branch
  • search support should be a runtime option
    • there should be a command line parameter added to PocoDoc to generate searchable SQLite DB
    • obviously, a precondition is SQLite built with FTS support
    • there should be a way to check at runtime if Data/SQLite supports FTS; only if it does can searchable content be produced (otherwise runtime error if searchable cmd line param was give)

@matejk matejk deleted the branch pocoproject:main April 15, 2024 11:20
@matejk matejk closed this Apr 15, 2024
@matejk matejk reopened this Apr 22, 2024
@matejk matejk changed the base branch from devel to main April 22, 2024 06:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

PocoDoc: search support
3 participants