Mark deprecated functionality with C++ attributes and resolve internal usage of deprecated functions #4551
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
matejk
force-pushed
the
4426-deprecated-functionality
branch
12 times, most recently
from
f2c5384
to
bc4b50a
Compare
aleks-f
requested changes
May 12, 2024
There was a problem hiding this comment.
I am not sure if @deprecated is needed/used by PocoDoc, @obiltschnig would know
matejk
force-pushed
the
4426-deprecated-functionality
branch
from
bc4b50a
to
3999dcd
Compare
matejk
commented
May 17, 2024
| @@ -85,13 +85,13 @@ class Foundation_API LocalDateTime | |||
| /// Creates a LocalDateTime from the UTC time given in dateTime, | |||
| /// using the time zone differential of the current time zone. | |||
|
|
|||
| //@ deprecated | |||
There was a problem hiding this comment.
@obiltschnig, @aleks-f: Some ctors/functions in this class seem not to have an alternative to be used. They are for example used in Dynamic/Var.h.
Is complete class deprecated?
matejk
commented
May 17, 2024
| //@deprecated | ||
| class RSAKey; | ||
| class [[deprecated]] ECKey; | ||
| class [[deprecated]] RSAKey; |
There was a problem hiding this comment.
@obiltschnig , what shall be used instead of these?
…eate valid binaries.
matejk
force-pushed
the
4426-deprecated-functionality
branch
from
3999dcd
to
f63afd3
Compare
matejk
force-pushed
the
4426-deprecated-functionality
branch
from
f63afd3
to
da8037a
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #4426.