Cache values when accessing test dependencies from live context #78
+16
−19
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
oronbz
commented
Apr 10, 2023
| #endif | ||
| XCTAssertEqual(reuseClient.count(), 0) | ||
| } | ||
| #if DEBUG |
There was a problem hiding this comment.
The modifications here are to adjust to the fact the failure only happens once now, since the next time, it'll pull it from cache
|
@stephencelis @mbrandonw , hope it's ok mentioning you here. any chance you can look into it? As our project switch more and more dependencies to swift-dependencies this has become a bigger of an issue for us. |
oronbz
force-pushed
the
cache_test_value
branch
from
413beb0 to
c157234
Compare
3 tasks
oronbz
force-pushed
the
cache_test_value
branch
from
c157234 to
525665d
Compare
stephencelis
approved these changes
Jan 22, 2024
There was a problem hiding this comment.
@oronbz Sorry for the delay. We've dug a bit more deeply into the problem and agree that we should be caching in this case. Thanks again for the PR!
|
Lovely. Thanks @stephencelis |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
#77