Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Mantine & Remix Upgrades #188

Closed
wants to merge 22 commits into from
Closed

Mantine & Remix Upgrades #188

wants to merge 22 commits into from

Conversation

carlosvq
Copy link
Contributor

@carlosvq carlosvq commented Nov 23, 2022 •
edited

Overview

This pull request re-adds the last changes we added to the portal related to the Mantine and Remix upgrades.

Type of change

  • Bug fix (non-breaking change; fixes an issue).
  • New feature (non-breaking change; adds functionality).
  • Breaking change (fix or feature that breaks existing functionality).
  • This change requires a documentation update.
  • Operational change.
  • Test Coverage.

Checklist

  • My code follows the style guidelines of this project
  • I have performed a self-review of my code
  • I have commented on my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • My changes generate no new warnings
  • I have added tests that prove my fix is effective or that my feature works
  • New and existing unit tests pass locally with my changes
  • Any dependent changes have been merged and published in downstream modules
  • I have checked my code and corrected any misspellings

Dependencies

"@emotion/react": "^11.10.4",
"@emotion/server": "^11.10.0",
"@mantine/core": "^5.6.2",
"@mantine/hooks": "^5.6.2",
"@mantine/remix": "^5.6.2",
"@pokt-foundation/pocket-blocks": "^2.0.1",
"@remix-run/node": "^1.7.4",
"@remix-run/react": "^1.7.4",
"@remix-run/vercel": "^1.7.4",
"graphql": "^16.6.0",
"graphql-request": "^5.0.0",
"@graphql-codegen/cli": "^2.13.11",
"@graphql-codegen/introspection": "^2.2.1",
"@graphql-codegen/typescript-graphql-request": "^4.5.8",
"@graphql-codegen/typescript-operations": "^2.5.6",

Test Configuration

The hardware stack you used to test your changes.
Fill in those that apply, and remove the rest.

  • Hardware: Apple M1 Pro
  • OS: 13.0.1
  • Node version: v16.18.0
  • PNPM version: v7.16.1

Evidence

No required.

@height
Copy link

height bot commented Nov 23, 2022 •
edited

This pull request has been linked to and will mark 4 tasks as "Done" when merged:

This pull request has also been linked to 2 additional tasks:

@carlosvq carlosvq marked this pull request as draft November 23, 2022 15:57
@vercel
Copy link

vercel bot commented Nov 23, 2022 •
edited

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Updated
pocket-portal ✅ Ready (Inspect) Visit Preview Dec 14, 2022 at 3:23PM (UTC)

@github-actions
Copy link

github-actions bot commented Nov 23, 2022 •
edited

Coverage Summary

Status Category Percentage Covered / Total
🔵 Lines 90.69% 7041 / 7763
🔵 Statements 90.69% 7041 / 7763
🔵 Functions 60.66% 182 / 300
🔵 Branches 83.78% 398 / 475
File Coverage
File Stmts % Branch % Funcs % Lines Uncovered Lines
app/components/application/AppAddressCard/AppAddressCard.tsx 98.85% 76.47% 100% 98.85%
app/components/application/AppAddressCard/index.ts 100% 100% 100% 100%
app/components/application/AppEndpointCard/AppEndpointCard.tsx 59.35% 47.05% 40% 59.35%
app/components/application/AppEndpointUrl/AppEndpointUrl.tsx 100% 100% 100% 100%
app/components/application/AppEndpointUrl/index.ts 100% 100% 100% 100%
app/components/application/AppKeysCard/AppKeysCard.tsx 100% 100% 100% 100%
app/components/application/AppKeysCard/index.ts 100% 100% 100% 100%
app/components/application/AppLatencyCard/AppLatencyCard.tsx 96.87% 88.88% 100% 96.87%
app/components/application/AppOverSessionLimitCard/AppOverSessionLimitCard.tsx 100% 100% 100% 100%
app/components/application/AppPlanDetails/AppPlanDetails.tsx 97.84% 100% 100% 97.84%
app/components/application/AppPlanDetails/index.ts 100% 100% 100% 100%
app/components/application/AppPlanLatestInvoiceCard/AppPlanLatestInvoiceCard.tsx 100% 40% 100% 100%
app/components/application/AppPlanLatestInvoiceCard/index.ts 100% 100% 100% 100%
app/components/application/AppPlanOverviewCard/AppPlanOverviewCard.tsx 100% 100% 100% 100%
app/components/application/AppPlanOverviewCard/index.ts 100% 100% 100% 100%
app/components/application/AppPlansOverview/AppPlansOverview.tsx 97.67% 100% 100% 97.67%
app/components/application/AppRadioCards/AppRadioCards.tsx 97.22% 80% 66.66% 97.22%
app/components/application/AppRequestsByOriginCard/AppRequestsByOriginCard.tsx 100% 100% 100% 100%
app/components/application/CalculateYourPricing/CalculateYourPricing.tsx 98.61% 92.3% 85.71% 98.61%
app/components/application/ChainWithImage/ChainWithImage.tsx 100% 75% 100% 100%
app/components/application/ChainWithImage/index.ts 100% 100% 100% 100%
app/components/application/ChainsDropdown/ChainsDropdown.tsx 97.5% 83.33% 50% 97.5%
app/components/application/ChainsDropdown/index.ts 100% 100% 100% 100%
app/components/application/ContactSalesForm/ContactSalesForm.tsx 99.39% 80% 100% 99.39%
app/components/application/ContactSalesForm/index.ts 100% 100% 100% 100%
app/components/application/FeedbackCard/FeedbackCard.tsx 100% 100% 100% 100%
app/components/application/FeedbackCard/index.ts 100% 100% 100% 100%
app/components/application/LegacyBannerCard/LegacyBannerCard.tsx 83.05% 75% 50% 83.05%
app/components/application/LegacyBannerCard/index.ts 100% 100% 100% 100%
app/components/application/NetworkPoktScanLatestBlockCard/NetworkPoktScanLatestBlockCard.tsx 97.67% 71.42% 100% 97.67%
app/components/application/NetworkPoktScanLatestBlockCard/index.ts 100% 100% 100% 100%
app/components/application/NetworkRelayPerformanceCard/NetworkRelayPerformanceCard.tsx 100% 100% 100% 100%
app/components/application/NetworkRelayPerformanceCard/index.ts 100% 100% 100% 100%
app/components/application/NetworkSuccessRateCard/NetworkSuccessRateCard.tsx 100% 100% 100% 100%
app/components/application/NetworkSuccessRateCard/index.ts 100% 100% 100% 100%
app/components/application/NetworkSummaryCard/NetworkSummaryCard.tsx 100% 100% 100% 100%
app/components/application/NetworkSummaryCard/index.ts 100% 100% 100% 100%
app/components/application/StopRemoveApp/StopRemoveApp.tsx 94.32% 62.5% 20% 94.32%
app/components/application/StopRemoveApp/index.ts 100% 100% 100% 100%
app/components/application/UsageChartCard/UsageChartCard.tsx 100% 88.88% 100% 100%
app/components/application/UsageChartCard/formatDailyRelaysForGraphing.ts 100% 100% 100% 100%
app/components/application/UsageChartCard/index.ts 100% 100% 100% 100%
app/components/shared/AnimatedLogo/AnimatedLogo.tsx 28.16% 100% 33.33% 28.16%
app/components/shared/AnimatedLogo/index.ts 100% 100% 100% 100%
app/components/shared/Card/Card.tsx 100% 100% 100% 100%
app/components/shared/Card/index.ts 100% 100% 100% 100%
app/components/shared/CardList/CardList.tsx 100% 50% 100% 100%
app/components/shared/CardList/index.ts 100% 100% 100% 100%
app/components/shared/CopyTextIcon/CopyTextIcon.tsx 100% 50% 66.66% 100%
app/components/shared/CopyTextIcon/index.ts 100% 100% 100% 100%
app/components/shared/Dropdown/Dropdown.tsx 100% 100% 100% 100%
app/components/shared/Dropdown/index.ts 100% 100% 100% 100%
app/components/shared/HelpTooltip/HelpTooltip.tsx 78.04% 66.66% 50% 78.04%
app/components/shared/HelpTooltip/index.ts 100% 100% 100% 100%
app/components/shared/Icons/IconDiscord.tsx 100% 100% 100% 100%
app/components/shared/Loader/Loader.tsx 64.28% 100% 50% 64.28%
app/components/shared/Loader/index.ts 100% 100% 100% 100%
app/components/shared/Modal/Modal.tsx 100% 100% 100% 100%
app/components/shared/Modal/index.ts 100% 100% 100% 100%
app/components/shared/Nav/Nav.tsx 90.47% 86.66% 83.33% 90.47%
app/components/shared/Nav/index.ts 100% 100% 100% 100%
app/components/shared/PoweredBy/PoweredBy.tsx 90.9% 50% 100% 90.9%
app/components/shared/PoweredBy/index.ts 100% 100% 100% 100%
app/components/shared/RevealIcon/RevealIcon.tsx 100% 100% 100% 100%
app/components/shared/RevealIcon/index.ts 100% 100% 100% 100%
app/components/shared/Table/Table.tsx 92.09% 93.1% 60% 92.09%
app/components/shared/Table/index.ts 100% 100% 100% 100%
app/components/shared/TextInput/TextInput.tsx 97.56% 94.11% 66.66% 97.56%
app/components/shared/TextInput/index.ts 100% 100% 100% 100%
app/context/FeatureFlagContext.tsx 56.52% 50% 20% 56.52%
app/context/TranslateContext.tsx 92.83% 66.66% 33.33% 92.83%
app/context/UserContext.tsx 76.19% 50% 14.28% 76.19%
app/hooks/useClipboard.tsx 100% 100% 100% 100%
app/locales/en.tsx 100% 100% 100% 100%
app/locales/fr.tsx 100% 100% 100% 100%
app/models/poktscan/poktscan.data.ts 100% 100% 100% 100%
app/models/portal/portal.data.ts 100% 100% 100% 100%
app/models/portal/sdk.ts 93.91% 100% 15.38% 93.91%
app/models/relaymeter/relaymeter.data.ts 100% 100% 100% 100%
app/models/stripe/stripe.data.ts 100% 100% 100% 100%
app/utils/analytics.ts 50.81% 100% 40% 50.81%
app/utils/applicationUtils.ts 52.94% 75% 25% 52.94%
app/utils/catchError.ts 86.66% 92.3% 100% 86.66%
app/utils/chainUtils.ts 88.44% 85.71% 36.36% 88.44%
app/utils/dayjs.ts 100% 100% 100% 100%
app/utils/environment.server.ts 100% 100% 100% 100%
app/utils/environment.ts 100% 100% 100% 100%
app/utils/formattingUtils.ts 100% 100% 100% 100%
app/utils/log.ts 100% 100% 75% 100%
app/utils/mathUtils.ts 94.28% 100% 50% 94.28%
app/utils/pocketUtils.ts 61.53% 100% 20% 61.53%
app/utils/safeRedirect.ts 100% 100% 100% 100%
app/utils/session.server.ts 74.78% 75% 50% 74.78%
app/utils/utils.ts 66.66% 88.23% 50% 66.66%
app/utils/known-chains/known-chains.ts 75.25% 68.42% 100% 75.25%
app/views/dashboard/apps/appId/layout/appIdLayoutView.tsx 94.58% 84.37% 42.85% 94.58%
app/views/dashboard/apps/appId/plan/planView.tsx 100% 100% 100% 100%
app/views/dashboard/apps/appId/security/securityView.tsx 67.18% 28.57% 15% 67.18%
app/views/dashboard/apps/contact-sales/contactSalesView.tsx 100% 100% 33.33% 100%
app/views/dashboard/apps/index/appsView.tsx 100% 100% 66.66% 100%
app/views/dashboard/apps/profile/profileView.tsx 100% 100% 85.71% 100%
app/views/network/networkView.tsx 90.44% 85.71% 50% 90.44%

@carlosvq carlosvq force-pushed the carlos/T-15769-fix-remix-upgrade-issues-in-the-portal branch from c2face4 to 452c582 Compare November 29, 2022 15:52
@carlosvq carlosvq force-pushed the carlos/T-15769-fix-remix-upgrade-issues-in-the-portal branch from f7d1629 to ed36756 Compare November 29, 2022 16:48
@lgtm-com
Copy link

lgtm-com bot commented Nov 29, 2022

This pull request introduces 1 alert when merging efc8f25 into e73de73 - view on LGTM.com

new alerts:

  • 1 for Unused variable, import, function or class

Heads-up: LGTM.com's PR analysis will be disabled on the 5th of December, and LGTM.com will be shut down ⏻ completely on the 16th of December 2022. Please enable GitHub code scanning, which uses the same CodeQL engine ⚙️ that powers LGTM.com. For more information, please check out our post on the GitHub blog.

@carlosvq carlosvq requested a review from kutoft November 30, 2022 13:57
@carlosvq carlosvq marked this pull request as ready for review November 30, 2022 13:57
kutoft
kutoft reviewed Nov 30, 2022
View reviewed changes
app/root.tsx Show resolved Hide resolved
kutoft
kutoft reviewed Nov 30, 2022
View reviewed changes
package.json Outdated Show resolved Hide resolved
@lgtm-com
Copy link

lgtm-com bot commented Dec 1, 2022

This pull request introduces 1 alert when merging 89da423 into 3f8f6b9 - view on LGTM.com

new alerts:

  • 1 for Unused variable, import, function or class

Heads-up: LGTM.com's PR analysis will be disabled on the 5th of December, and LGTM.com will be shut down ⏻ completely on the 16th of December 2022. Please enable GitHub code scanning, which uses the same CodeQL engine ⚙️ that powers LGTM.com. For more information, please check out our post on the GitHub blog.

@carlosvq carlosvq requested a review from kutoft December 1, 2022 20:21
@lgtm-com
Copy link

lgtm-com bot commented Dec 2, 2022

This pull request introduces 1 alert when merging 112798f into 3f8f6b9 - view on LGTM.com

new alerts:

  • 1 for Unused variable, import, function or class

Heads-up: LGTM.com's PR analysis will be disabled on the 5th of December, and LGTM.com will be shut down ⏻ completely on the 16th of December 2022. Please enable GitHub code scanning, which uses the same CodeQL engine ⚙️ that powers LGTM.com. For more information, please check out our post on the GitHub blog.

@carlosvq
Mantine & Remix Upgrades
6cdd8e1 
Revert "Revert "T-15443 library updates""

This reverts commit 03cb1ea.

Revert "Revert "updates""

This reverts commit 210777f.

Revert "Revert "updates""

This reverts commit 4c9fac0.

Revert "Revert "updates""

This reverts commit 055fbaa.

Revert "Revert "remove textColor""

This reverts commit 5bc0d82.

Revert "Revert "withCSSVariables""

This reverts commit 9090718.

Revert "Revert "add pocket blocks v2.0.1""

This reverts commit fd051cb.

Revert "Revert "update props order""

This reverts commit 38d5264.

Revert "Revert "add root updates""

This reverts commit bcc9788.

Revert "Revert "updates""

This reverts commit 1f4061e.

Revert "Revert "updates""

This reverts commit 7a76a24.

Revert "Revert "updates""

This reverts commit d5ad709.

Revert "Revert "update cache-key""

This reverts commit 71ad474.

Revert "Revert "update gql""

This reverts commit 4d0d863.
@carlosvq
add updates
fb842ad
@carlosvq
fix lint
99ba0d9
@carlosvq
fix auth0 links issue
09f57cf
@carlosvq
ui changes
48776aa
@carlosvq
Add timeout to the error metrics
6280848
PseudoMera
PseudoMera previously approved these changes Dec 12, 2022
View reviewed changes
Copy link
Contributor

@PseudoMera PseudoMera left a comment •
edited

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I feel I lack context but code looks good to me so approved!

carlosvq
carlosvq commented Dec 13, 2022
View reviewed changes
app/components/shared/Header/Header.tsx Show resolved Hide resolved
vitest.config.ts
@@ -15,7 +15,7 @@ export default defineConfig({
reporter: ["text", "html", "json-summary"],
lines: 50,
branches: 50,
functions: 50,
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I have updated this to 45 due to the Mantine changes; in the future, I have plans to create a testing test coverage strategy.

@carlosvq
Copy link
Contributor Author

Due to all of the issues Mantine is having with Remix by the CSS-in-JS libraries, we are canceling the libraries upgrade for now.

mantinedev/mantine#2311

cc @kutoft

@carlosvq carlosvq closed this Dec 14, 2022
@RabeeAbuBaker RabeeAbuBaker deleted the carlos/T-15769-fix-remix-upgrade-issues-in-the-portal branch March 19, 2024 00:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kutoft kutoft Awaiting requested review from kutoft

@PseudoMera PseudoMera Awaiting requested review from PseudoMera

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@carlosvq @kutoft @PseudoMera