-
-
Notifications
You must be signed in to change notification settings - Fork 1.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix(rust, python)!: don't parse inputs without hour and minute components as pl.Datetime (use pl.Date instead) #8850
Closed
MarcoGorelli
wants to merge
8
commits into
pola-rs:main
from
MarcoGorelli:parse-datetime-as-datetime
Closed
fix(rust, python)!: don't parse inputs without hour and minute components as pl.Datetime (use pl.Date instead) #8850
MarcoGorelli
wants to merge
8
commits into
pola-rs:main
from
MarcoGorelli:parse-datetime-as-datetime
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
breaking
Change that breaks backwards compatibility
fix
Bug fix
python
Related to Python Polars
rust
Related to Rust Polars
labels
May 15, 2023
MarcoGorelli
force-pushed
the
parse-datetime-as-datetime
branch
from
May 15, 2023 10:00
d6824b2
to
a8d4b22
Compare
…ents as pl.Datetime (use pl.Date instead)
MarcoGorelli
force-pushed
the
parse-datetime-as-datetime
branch
from
May 16, 2023 08:46
0e925de
to
3f0f4f5
Compare
MarcoGorelli
added
the
do not merge
This pull requests should not be merged right now
label
May 19, 2023
2 tasks
@MarcoGorelli any update on this? Or shouldn't we include this in 0.18 and do we first need to iron things out? |
hey - just wanted to check we were aligned, are you on board with the reasoning in #8849 (comment) ? If so I'll resolve the conflicts and push |
superseded by #9044 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
breaking
Change that breaks backwards compatibility
do not merge
This pull requests should not be merged right now
fix
Bug fix
python
Related to Python Polars
rust
Related to Rust Polars
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
closes #8849
This makes things slightly inconvenient for anyone previously parsing
'2020-01-01'
asDatetime
, as they need to parseDate
and then cast toDatetime
, but better than silently dropping the 'hour' component IMOTo clarify:
Current:
Here: