-
Notifications
You must be signed in to change notification settings - Fork 31
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Generate code #86
base: main
Are you sure you want to change the base?
Generate code #86
Conversation
Codecov Report
@@ Coverage Diff @@
## master #86 +/- ##
==========================================
- Coverage 99.19% 98.97% -0.23%
==========================================
Files 12 13 +1
Lines 749 778 +29
==========================================
+ Hits 743 770 +27
- Misses 6 8 +2
Continue to review full report at Codecov.
|
0caa799
to
6416ee2
Compare
From #89 (comment):
|
a7f6276
to
324c1dd
Compare
Work in progress. I plan to make small refactors and API changes to the library as I progress.
To begin with, the enumerations no longer use
auto()
, and I introduced an attrs hook to transform the fields with an enumeration type.I now have to figure out what to do with the defaults, since the library annotations have been wrong since the beginning:
name: int = attr.ib(default=None)
is invalid, and it should haveOptional[int]
as type instead.