Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Elysium networks #10077

Open
wants to merge 15 commits into
base: master
Choose a base branch
from
Open

Elysium networks #10077

wants to merge 15 commits into from

Conversation

slmnV0
Copy link

@slmnV0 slmnV0 commented Dec 5, 2023

Add Elysium Networks in TestNet and MainNet

Copy link
Member

@jacogr jacogr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Some small changes required to make the CI build pass.

packages/apps-config/src/endpoints/production.ts Outdated Show resolved Hide resolved
packages/apps-config/src/endpoints/testing.ts Outdated Show resolved Hide resolved
@slmnV0 slmnV0 requested a review from jacogr December 19, 2023 07:23
Copy link
Member

@jacogr jacogr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Some suggested linting fixes to make CI happy.

packages/apps-config/src/endpoints/production.ts Outdated Show resolved Hide resolved
packages/apps-config/src/endpoints/testing.ts Outdated Show resolved Hide resolved
packages/apps-config/src/endpoints/testing.ts Outdated Show resolved Hide resolved
@slmnV0 slmnV0 requested a review from jacogr December 19, 2023 13:01
Copy link
Member

@jacogr jacogr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Linting seems to be passing now (it is generally easier to run them locally, auto-fix takes care of the most)

Last failure is due to alphabetical ordering, see -

https://github.com/polkadot-js/apps/actions/runs/7263525247/job/19789025833?pr=10077#step:4:240

@slmnV0 slmnV0 requested a review from jacogr December 22, 2023 07:05
Copy link
Member

@jacogr jacogr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

There is an ordering issue indicated on the CI test - https://github.com/polkadot-js/apps/actions/runs/7407424678/job/20332033512?pr=10077#step:4:224

(The conflicts can be resolved by just merging in master)

@slmnV0 slmnV0 requested a review from jacogr January 23, 2024 05:52
@slmnV0
Copy link
Author

slmnV0 commented Jan 23, 2024

Hey, @jacogr what if execute the workflow before your approval? This will help to debug things quickly. I executed all
the following steps & all work fine except yarn lint (It's throwing an error incorrect header header/header in elysiumPNG.ts file but that's not making sense)

step: ['lint', 'test', 'build:code', 'build:i18n', 'build:electron']

@jacogr Please review this Action https://github.com/polkadot-js/apps/actions/runs/7621677199 this is the latest one.

https://github.com/polkadot-js/apps/actions/runs/7621677199

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants