Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix issue with optional rpc parameters. #9627

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Fix issue with optional rpc parameters. #9627

wants to merge 1 commit into from

Conversation

Neopallium
Copy link
Contributor

@Neopallium Neopallium commented Jun 23, 2023 •
edited

This change allows correct handling of Option<T> rpc parameter types. The filter was removing all null values, but those are needed for Option<T> parameters. The isOptional: true can't be used when mixing optional parameters with required parameters.

@Neopallium
Copy link
Contributor Author

An example of an RPC endpoint that has this issue see the asset.canTransfer endpoint for Polymesh:
https://polkadot.js.org/apps/?rpc=wss%3A%2F%2Fmainnet-rpc.polymesh.network#/rpc

Leave the from_custodian and to_custodian parameters unset. You can use 0x for the did fields and for the ticker, or just leave them empty.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
Polkadot-js general project board
Status: In Review
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
1 participant
@Neopallium