Support BTreeMap and fix rpc optional #9911
Conversation
|
@Neopallium I have this on my list to review, and will do it as soon as possible so we can get this in. |
| @@ -61,9 +60,9 @@ function Vector ({ className = '', defaultValue, isDisabled = false, label, onCh | |||
| useEffect((): void => { | |||
| inputParams.length && | |||
| setParams((prev) => | |||
| getParams(inputParams, prev, isDisabled ? (defaultValue.value as RawParam[] || []).length : count) | |||
| getParams(inputParams, prev, isDisabled ? values.length : count) | |||
| @@ -72,7 +72,7 @@ function Selection ({ queueRpc }: Props): React.ReactElement<Props> { | |||
| (): void => queueRpc({ | |||
| rpc, | |||
| values: values | |||
| .filter(({ value }) => !isNull(value)) | |||
| .filter(({ value }, idx) => !rpc.params[idx].isOptional || !isNull(value)) | |||
There was a problem hiding this comment.
Apologies but can you give a brief explanation as to what this is fixing? Thanks again.
There was a problem hiding this comment.
The isOptional setting only really works for last parameters, not for a mix of Option and non-Option parameters. So the fix keeps null values for isOptional=false parameters.
We are using this fix here: https://mainnet-app.polymesh.network/#/rpc
Open the asset.canTransferGranular endpoint and just click the submit button (don't need to fill in values).
To see the error try the same endpoint using the Polkadot.js.org app without the fix: https://polkadot.js.org/apps/?rpc=wss%3A%2F%2Fmainnet-rpc.polymesh.network#/rpc
The error is:
1: asset.canTransferGranular: CanTransferGranularReturn
Expected 7 parameters (1 optional), 4 found instead
There was a problem hiding this comment.
Ahh okay, thanks so much for the explanation. Makes sense
|
Just needs a |
Co-authored-by: Tarik Gul <47201679+TarikGul@users.noreply.github.com>
Neopallium
force-pushed
the
support_btreemap_fix_rpc_optional
branch
from
b478f4a
to
24f3f99
Compare
|
|
Closes issue #1723