Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs: update readme #1336

Open
wants to merge 3 commits into
base: master
Choose a base branch
from
Open

Conversation

ltfschoen
Copy link

No description provided.

@Tbaut
Copy link
Contributor

Tbaut commented Mar 24, 2024

These are very specific changes to your needs. There is no need for changing the name, or install nvm.

@ltfschoen
Copy link
Author

ltfschoen commented Mar 24, 2024

These are very specific changes to your needs. There is no need for changing the name, or install nvm.

i've updated it so use of nvm is optional and removed other stuff that isn't essential

note that my Firefox version 123.0 didn't have a "Enable add-on debugging" checkbox to check, so mentioned only to do that if it's available so users don't spend too much time trying to find it or asking for support if it's not there

- go to `about:debugging#addons`
- check "Enable add-on debugging"
- click on "Load Temporary Add-on" and point to `packages/extension/build/manifest.json`
- go to "This Firefox" at `about:debugging#addons`
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

What does "This Firefox" mean?

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

it's a menu item in latest Firefox 124.0.1 as shown below. if i go to about:debugging#addons it redirects me to about:debugging#/runtime/this-firefox

Screenshot 2024-03-25 at 8 01 44 am

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is the default tab when going to about:debugging#addons, so I suggest to remove this mention as it may change.

Suggested change
- go to "This Firefox" at `about:debugging#addons`
- go to `about:debugging#addons`

- check "Enable add-on debugging"
- click on "Load Temporary Add-on" and point to `packages/extension/build/manifest.json`
- go to "This Firefox" at `about:debugging#addons`
- check "Enable add-on debugging" (if available)
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

this is not present in new versions, let's remove it then.

Suggested change
- check "Enable add-on debugging" (if available)

- go to `about:debugging#addons`
- check "Enable add-on debugging"
- click on "Load Temporary Add-on" and point to `packages/extension/build/manifest.json`
- go to "This Firefox" at `about:debugging#addons`
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is the default tab when going to about:debugging#addons, so I suggest to remove this mention as it may change.

Suggested change
- go to "This Firefox" at `about:debugging#addons`
- go to `about:debugging#addons`

- if developing, after making changes - reload the extension
3. When visiting `https://polkadot.js.org/apps/` it will inject the extension
- edit the extension settings to "Run in Private Windows" if necessary
- click the puzzle icon, then click the gear icon next to the "polkadot{.js} extension (development only)" extension and choose "Pin to Toolbar"
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is really not needed either and can change in the future. I'd remove.

Suggested change
- click the puzzle icon, then click the gear icon next to the "polkadot{.js} extension (development only)" extension and choose "Pin to Toolbar"

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants