Cross extensions messaging feature #935
Open
+21
−2
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The user still need to authorize the 3rd party extension connection : |
LaurentTrk
commented
Dec 21, 2021
| @@ -28,7 +28,7 @@ function WebsiteEntry ({ className = '', info, toggleAuth, url }: Props): React. | |||
| return ( | |||
| <div className={`${className} ${info.isAllowed ? 'allowed' : 'denied'}`}> | |||
| <div className='url'> | |||
| {url} | |||
| {info.origin} ({url}) | |||
There was a problem hiding this comment.
Optional change: that improves the website listing when using extensions (extension url is the extension id which means nothing to the user)
|
Hi @jacogr, any thoughts on this one ? |
|
Hi @jacogr, I am building Polkadot Wallet called Onyx as Chrome extension which will display my staked and free coins based on wallet addresses I have loaded through this extension. I would really appreciate this PR reviewed and merged as soon as possible. Thannks :) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hi all
Following the discussions in #849 and #912, you will find in this PR the modifications to enable the use of this extension by others, through Cross Extensions Messaging.
I will be happy to discuss this further !
Thanks.