Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix for failing dependabot PRs #395

Merged
merged 1 commit into from
Mar 1, 2023
Merged

Conversation

justinpolygon
Copy link
Contributor

@justinpolygon justinpolygon commented Mar 1, 2023

We have multiple PRs from dependabot where the linting and unit tests are failing with the error below. Turns out that dependabot is running an updated version of poetry where the syntax of the poetry.lock has been updated. So, when dependabot submits patches, using the new syntax, our version of the abatilo/actions-poetry@v2.0.0 github action cannot parse the new poetry.lock syntax and fails. There is no support to revert dependabot to an older version of poetry (open issue here: dependabot/dependabot-core#1556).

Error we are seeing:

[NonExistentKey]
'Key "files" does not exist.'
Error: Process completed with exit code 1.

So, it seems our only fix is to update the gitub action to support the poetry version that dependabot is using so we can parse the poetry.lock syntax. I have run a successful test by manually tweaking the github actions along with bumping the version of types-setuptools and got the linting and tests to pass (#394).

My plan here is to bump the version of the github action with this PR. Then, we'll get dependabot to recreate it's patches and we should have an automated system again.

Here's the PRs this patch will unblock:

@justinpolygon
Copy link
Contributor Author

@jbonzo here's the root cause after some digging on why things were failing.

Copy link
Collaborator

@jbonzo jbonzo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great find

@justinpolygon justinpolygon merged commit 7567479 into master Mar 1, 2023
@justinpolygon justinpolygon deleted the pr-abatilo/actions-poetry@v2 branch March 1, 2023 15:30
justinpolygon added a commit that referenced this pull request Mar 28, 2023
In #395 we fixed a gitub action to support the poetry version that dependabot is using so we can parse the poetry.lock syntax. However, this broke the automated release pipeline to https://pypi.org/project/polygon-api-client/ since we needed to update it's ability to parse the new poetry.lock syntax too.
justinpolygon added a commit that referenced this pull request Mar 28, 2023
In #395 we fixed a gitub action to support the poetry version that dependabot is using so we can parse the poetry.lock syntax. However, this broke the automated release pipeline to https://pypi.org/project/polygon-api-client/ since we needed to update it's ability to parse the new poetry.lock syntax too.
justinpolygon added a commit that referenced this pull request Mar 28, 2023
In #395 and #413 we fixed a gitub action to support the poetry version that dependabot is using so we can parse the poetry.lock syntax. However, this broke the automated release pipeline to https://pypi.org/project/polygon-api-client/ since we needed to update it's ability to parse the new poetry.lock syntax too.

The impact here is that we have not released 1.8.x.
justinpolygon added a commit that referenced this pull request Mar 28, 2023
In #395 and #413 we fixed a gitub action to support the poetry version that dependabot is using so we can parse the poetry.lock syntax. However, this broke the automated release pipeline to https://pypi.org/project/polygon-api-client/ since we needed to update it's ability to parse the new poetry.lock syntax too.

The impact here is that we have not released 1.8.x.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants