(#8) - Remove a result XML file if a source file no longer exist #74
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## master #74 +/- ##
============================================
+ Coverage 53.96% 54.30% +0.34%
- Complexity 32 34 +2
============================================
Files 8 8
Lines 265 267 +2
Branches 24 25 +1
============================================
+ Hits 143 145 +2
+ Misses 119 118 -1
- Partials 3 4 +1
📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more |
|
@mximp Please, review |
|
@pollyvolk please always place reference to an issue within PR's description. |
mximp
reviewed
Dec 5, 2022
| @@ -68,8 +68,11 @@ public Program(final Path src, final Path tmp) { | |||
| public XML apply(final String locator) throws Exception { | |||
| final String[] parts = locator.split("\\."); | |||
| final String name = parts[1]; | |||
| final Path xml = this.temp.resolve(String.format("%s.xml", name)); | |||
| final Path src = this.sources.resolve(String.format("%s.eo", name)); | |||
| final Path xml = this.temp.resolve(String.format("%s.xml", name)).toAbsolutePath(); | |||
There was a problem hiding this comment.
@pollyvolk what caused the path to be changed to absolute? Were there issues with previous version of the code?
There was a problem hiding this comment.
@mximp You are right, this change is redundant, I will remove it
mximp
approved these changes
Dec 5, 2022
|
@yegor256 please merge |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
#8
How it was:
A user runs Polystat with
--files sources --tmp result, and there is a filesources/test.eo. The result of the analysis will be saved toresult/test.xml. If the user renames or deletes the filesources/test.eoand runs the same command again, Polystat will print the previous correct result, taking it fromresult/test.xml, not throwing an exception.After changes:
In the same case Polystat will throw a
FileNotFoundException.It throws an exception several times for each running
Analysis.