Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

deployment: enable multi-arch release images #1643

Merged
merged 1 commit into from Dec 3, 2020
Merged

deployment: enable multi-arch release images #1643

merged 1 commit into from Dec 3, 2020

Conversation

travisgroth
Copy link
Contributor

@travisgroth travisgroth commented Dec 1, 2020 •
edited

Summary

Begin publishing multi-arch docker images at pomerium/pomerium

  • Supports arm64 and amd64
  • Standardizes both architectures on gcr.io/distroless
  • Fixes a linker error when running embedded envoy on arm images

Related issues

Closes #268
Closes #1644

Checklist:

  • add related issues
  • updated docs
  • updated UPGRADING.md
  • ready for review

@codeclimate
Copy link

codeclimate bot commented Dec 1, 2020 •
edited

Code Climate has analyzed commit 48a1e77 and detected 0 issues on this pull request.

View more on Code Climate.

@codecov
Copy link

codecov bot commented Dec 1, 2020 •
edited

Codecov Report

Merging #1643 (48a1e77) into master (b121e43) will not change coverage.
The diff coverage is n/a.

@@          Coverage Diff           @@
##           master   #1643   +/-   ##
======================================
  Coverage    55.5%   55.5%           
======================================
  Files         126     126           
  Lines        9171    9171           
======================================
  Hits         5094    5094           
- Misses       3587    3588    +1     
+ Partials      490     489    -1
Impacted Files Coverage Δ
pkg/storage/redis/redis.go 71.6% <0.0%> (ø)
internal/cmd/pomerium/pomerium.go 59.2% <0.0%> (ø)

@travisgroth travisgroth marked this pull request as ready for review December 2, 2020 02:50
@travisgroth travisgroth requested a review from a team as a code owner December 2, 2020 02:50
@travisgroth travisgroth requested review from nhayfield and desimone and removed request for nhayfield December 2, 2020 02:50
@travisgroth travisgroth marked this pull request as draft December 2, 2020 04:25
@travisgroth travisgroth mentioned this pull request Dec 2, 2020
Closed
@travisgroth travisgroth marked this pull request as ready for review December 2, 2020 22:58
@travisgroth travisgroth merged commit 23249c8 into pomerium:master Dec 3, 2020
@travisgroth travisgroth deleted the docker_multiarch branch December 3, 2020 16:07
@travisgroth travisgroth mentioned this pull request Dec 14, 2020
Merged
5 tasks
@jawabuu jawabuu mentioned this pull request Jul 24, 2021
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@desimone desimone desimone approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Pomerium arm64 docker images don't listen on port 443 deployment: add multi-arch docker support
2 participants
@travisgroth @desimone