Move docker image builds to Travis CI #288
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Faster - Multi-Arch works correctly with Docker CI 19.03
Codecov Report
@@ Coverage Diff @@
## master #288 +/- ##
======================================
Coverage 86.2% 86.2%
======================================
Files 49 49
Lines 2894 2894
======================================
Hits 2495 2495
Misses 308 308
Partials 91 91 |
desimone
approved these changes
Aug 29, 2019
|
Code Climate has analyzed commit b2d3b1e and detected 0 issues on this pull request. The test coverage on the diff in this pull request is 100.0% (50% is the threshold). This pull request will bring the total coverage in the repository to 86.5% (0.0% change). View more on Code Climate. |
|
@travisgroth would this change the docs for docker at all? https://www.pomerium.io/docs/releases.html#docker |
It should not unless I missed something. The workflow should match existing semantics for the moment. |
yegle
pushed a commit
to yegle/pomerium
that referenced
this pull request
Sep 7, 2019
- Faster - Multi-Arch works correctly with Docker CI 19.03
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Related: #284
It seems like Docker Hub automated builds really don't handle ARM builds correctly. This PR moves image testing as well as publishing into Travis. This should set the stage for moving to multi-arch as well.
Checklist: