-
Notifications
You must be signed in to change notification settings - Fork 279
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add runtime flag to allow disabling config hot-reload (#5079) #5112
base: main
Are you sure you want to change the base?
Conversation
Also implemented an alternative solution to this issue here: d75e1ca |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks, looks good!
config/config_source.go
Outdated
if cfg.Options.IsRuntimeFlagSet(RuntimeFlagConfigHotReload) { | ||
src.watcher.Watch(ctx, []string{configFile}) | ||
} else { | ||
log.Warn(ctx).Msg("hot reload disabled") |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think we say not to log at warning level (see https://www.pomerium.com/docs/community/contributing#logging) — although I'm sure we're not 100% consistent about this. Still, maybe log at Info()
here?
Summary
This adds the runtime flag
config_hot_reload
(default true) that allows enabling or disabling the hot-reload mechanism for the config file and any other files referenced within it.Related issues
#5079
User Explanation
Checklist
improvement
/bug
/ etc)