Handle Ctrl-Shift-u to input unicode #70
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
snaggen
force-pushed
the
unicode_input
branch
2 times, most recently
from
ec603c3
to
2870b21
Compare
|
I have updated this to master, it is now much less intrusive. The only thing for this feature would be to show some special unicode indication at the cursor (possibly 'Ⓤ' ) when you are in unicode input mode. However, the cursor handling still looks quite limited, so I'm not sure how to do this. Now, all terminals doesn't have this, so I think it is still usable without. |
|
Maybe this should be handled higher up in the input stack though, but I'm not sure that is possible to do in a good way. |
snaggen
force-pushed
the
unicode_input
branch
from
2870b21
to
ea4ceae
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I have created a small state machine in terminal_box. By pressing Ctrl-shift-u, the input gets in to Unicode state, after that, all ascii hex digits are stored in a Vec. Then on any non-ascii hex digit or modifier change, the stored digits are converted to the unicode character they represent and sent to the terminal.