RFC: Maximize horizontal use of terminal view #80
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* Presumably, the TODO about window resizing interfering with scrolling is not applicable anymore with the existence of padding from the pane grid container. So, set `core.window.content_container` to false. * Pane grid container didn't follow the selected theme. So, set style on it to fix that. Signed-off-by: Mohammad AlSaleh <CE.Mohammad.AlSaleh@gmail.com>
This gets rid of the spare pixels at the end of lines that don't fit into a column. Signed-off-by: Mohammad AlSaleh <CE.Mohammad.AlSaleh@gmail.com>
* Don't clamp cols to before the scrollbar rectangle. * Auto-hide the scrollbar if a pane is not focused, or if there is no mouse activity. Signed-off-by: Mohammad AlSaleh <CE.Mohammad.AlSaleh@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
A couple of proposed changes on top of #79. This is scratching an itch I always had with
cosmic-term. But others may consider the changes proposed here overkill.Scrollback Changes
Text changes
Slightly increase font size to get rid of the spare pixels that don't fit into a column at the end of a line.
Screenshots
These are taken with OneHalfDark on Light for clarity.
Current
With #79
With scrollback changes
With font size increase
This fixes an issue that also exists in
alacritty. But I never saw it in the previous terminals I used.