Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: concurrently load & parse fonts #249

Merged
merged 3 commits into from
Jun 5, 2024
Merged

feat: concurrently load & parse fonts #249

merged 3 commits into from
Jun 5, 2024
+64 −1

Conversation

Itsusinn
Copy link
Contributor

@Itsusinn Itsusinn commented Apr 28, 2024 •
edited

This will reduce load time from 2376ms to 388ms when loading many huge fonts

@Itsusinn Itsusinn mentioned this pull request Apr 28, 2024
Closed
@Itsusinn
Copy link
Contributor Author

@jackpot51 Could you please take a look?

@Itsusinn
Copy link
Contributor Author

Itsusinn commented Apr 28, 2024 •
edited

https://docs.rs/rayon-core/1.12.1/rayon_core/index.html#global-fallback-when-threading-is-unsupported

I just find rayon supports no_std, maybe it's unnecessary to add rayon feature-gate?

@CryZe
Copy link
Contributor

CryZe commented Apr 28, 2024 •
edited

That's not the same as no_std. If the crate doesn't have a std feature (and otherwise uses std features), then it doesn't support no_std.

@Itsusinn
Copy link
Contributor Author

That's not the same as no_std. If the crate doesn't have a std feature (and otherwise uses std features), then it doesn't support no_std.

Understood

genusistimelord
genusistimelord suggested changes Jun 4, 2024
View reviewed changes
Copy link
Contributor

@genusistimelord genusistimelord left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Everything But the feature itself, being added as a default, looks good. Once that is fixed I think this would be ready to merge as I see no issues coming from this. @jackpot51

Cargo.toml Outdated Show resolved Hide resolved
genusistimelord
genusistimelord approved these changes Jun 5, 2024
View reviewed changes
Copy link
Contributor

@genusistimelord genusistimelord left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks much better thank you

@jackpot51 jackpot51 merged commit 39c4e3e into pop-os:main Jun 5, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@genusistimelord genusistimelord genusistimelord approved these changes

@jackpot51 jackpot51 jackpot51 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@Itsusinn @CryZe @genusistimelord @jackpot51