Add NVME temperatures in fan speed calculation #413
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Implement a second fan curve for NVME temperatures, and take the maximum fan speed from the CPU duty curve and the NVME duty curve and use that to set fan speed. The NVME fan curve is hardcoded to a single table assuming 70 degrees Celsius is the hottest allowable temperature (i.e., the fans should already be at 100% before 70 degrees is reached). Signed-off-by: Erich Ritz <erich.public@protonmail.com>
|
This tries to address #412 I tested the logic where sensor type "nvme" doesn't exist by recompiling with the match string set to "nvme__" instead of "nvme" to simulate no NVME drive sensors, and the code worked as expected. Here is some log file output with this patch applied: And here is the log output with the simulated no NVME drives: |
|
I'm not a Rust programmer! You can tell I did a lot of copy/paste and tried to mimic the existing logic as much as possible. I'm sure there are better ways to accomplish what I'm trying to do. But this works for me. Also, as mentioned in the Issue report, this is all tested on a Thelio Massive: |
|
I've been running with this patch for a few days now. Temps on the SSDs and HDDs are much lower now. HDD temp isn't used for fan speed calculation, but because the fans are running hard now due to SSD temps the HDD temp is now in an acceptable range: And yes, I am doing heavy I/O right now. I'm copying my data off the HDDs onto the 2 new SSDs. Here are some plots from the last roughly 36 hours. You can see the temps drop when my 2 monitors turn off overnight, enough that the fan command drops below 100%.
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Implement a second fan curve for NVME temperatures, and take the maximum fan speed from the CPU duty curve and the NVME duty curve and use that to set fan speed.
The NVME fan curve is hardcoded to a single table assuming 70 degrees Celsius is the hottest allowable temperature (i.e., the fans should already be at 100% before 70 degrees is reached).