Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Accept accentued chars #41

Closed
wants to merge 1 commit into from
Closed

Accept accentued chars #41

wants to merge 1 commit into from

Conversation

Drulac
Copy link

@Drulac Drulac commented Mar 22, 2024

Hello 😁 !

Issue

I opened an issue on the EdgeJS repo before understanding it's relative to a Poppinss method : #151

If I run this bunch of code

sentenceCase('bon état')
sentenceCase('bon etat')
camelCase('bon état')

It output me

Bon tat
Bon etat
bonEtat

the é char is truncated. Same for the àchar.

❓ Type of change

  • [ x] 🐞 Bug fix (a non-breaking change that fixes an issue)
  • 👌 Enhancement (improving an existing functionality like performance)
  • ✨ New feature (a non-breaking change that adds functionality)
  • ⚠️ Breaking change (fix or feature that would cause existing functionality to change)

📚 Description

Here a fix, adding all accentued letters to the regex, to stop losing them.

It resolve the issue

📝 Checklist

  • [x ] I have read the contribution guide.
  • [x ] I have linked an issue or discussion.
  • I have updated the documentation accordingly.

I'm not sure if documentation update is required in this case ?

Have a good day and thanks for your work 😃 !

Adding all accentued letters to the regex, to stop losing them
@thetutlage
Copy link
Member

thetutlage commented Mar 27, 2024

Can you please share what the expected outputs are?

@Drulac
Copy link
Author

Drulac commented Mar 30, 2024

Hello !

If I run this bunch of code

sentenceCase('bon état')
sentenceCase('bon etat')
camelCase('bon état')

It output me

Bon tat
Bon etat
bonEtat

I was expecting this :

Bon état
Bon etat
bonÉtat //or bonEtat

Copy link

stale bot commented May 30, 2024

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions.

@stale stale bot added the Status: Abandoned Dropped and not into consideration label May 30, 2024
@stale stale bot closed this Jun 6, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Status: Abandoned Dropped and not into consideration
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants