add error handler to subscribe #785
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Can you update the Typescript definition to include this please? |
|
@mattbishop done. Happy to add a test case for it as well. But I am not sure what would be best way to go about it. Specifically what's the best way to stub the stream in test to force an error? |
|
@Louis-Tian I have some other tests where I just terminate the backend. Perhaps that's a way forward? |
|
@porsager That's kind of what I am doing in the error handler anyway so that will work for me. Just think it would be better to let the user to decide to what do? But if there is other things that require a direct termination then I guess it make perfect sense to just leverage on that. |
|
This already seems to be merged, so I don't understand why the PR is still open. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Related to #757.
Expose a error handler on the subscribe function so any error happened while streaming replica can be handled in user space.